Skip to content

Fixes for wave kinematics #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes for wave kinematics #77

wants to merge 3 commits into from
+33 −16

Conversation

@tridelat
Copy link
Collaborator

@tridelat tridelat commented Nov 24, 2025

This patch fixes the following issues:

  • Add wave stretching option to regular waves
  • Deep water check done with a common function (condition k*h>89.4 to be considered deep water)
  • Wheeler wave stretching done with a common function, and corrected when mwl=/=0

@tridelat tridelat requested a review from dav-og November 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dav-og dav-og Awaiting requested review from dav-og

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tridelat