Skip to content

Make errors stack traces of createPacketBuffer readable #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zardoy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make errors stack traces of createPacketBuffer readable #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0376f
readable createPacketBuffer errors
zardoy Apr 28, 2024
f8759d1
silly mistakes
zardoy Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ class CompiledProtodef {
const buffer = Buffer.allocUnsafe(length)
tryCatch(() => this.write(packet, buffer, 0, type),
(e) => {
e.message = `Write error for ${e.field} : ${e.message}`
let packetStr = ''
try { packetStr = JSON.stringify(packet) } catch (err) { try { packetStr = String(packet) } catch (err) {} }
e.message = `Write error for ${e.field} in ${packetStr} : ${e.message}`
throw e
})
return buffer
Expand Down
6 changes: 4 additions & 2 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ function addErrorField (e, field) {
throw e
}

function tryCatch (tryfn, catchfn) {
try { return tryfn() } catch (e) { catchfn(e) }
function tryCatch(tryfn, catchfn) {
const oldLimit = Error.stackTraceLimit
Error.stackTraceLimit = Math.max(40, oldLimit)
try { return tryfn() } catch (e) { catchfn(e) } finally { Error.stackTraceLimit = oldLimit }
}

function tryDoc (tryfn, field) {
Expand Down