Only keep track of recently used stacks in memory + unified storage #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
This should - as far as we know - eliminate unbounded memory growth. To avoid memory leaks, we only evict "root" stacks from the cache.
This should - as far as we know - eliminate unbounded memory growth. To avoid memory leaks, we only evict "root" stacks from the cache.
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: vicsn <victor.s.nicolaas@protonmail.com>
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: vicsn <victor.s.nicolaas@protonmail.com>
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: vicsn <victor.s.nicolaas@protonmail.com>
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: vicsn <victor.s.nicolaas@protonmail.com>
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: vicsn <victor.s.nicolaas@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Combines #2591 + #2590 to see if we can make CI happy.
Remaining issues:
test_get_blockandtest_load_uncheckedexpect different metadata.ledger-with-rocksdbandsynthesizer(also on another PR, even with --test-threads=1).synthesizer-integrationbecause oftest_rand.aleo/rand_chacha_check, which internal state changed?