-
Notifications
You must be signed in to change notification settings - Fork 15
EIP-7002 #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7002 #132
Conversation
df4ec11 to
9a6652d
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
|
||
| calldatas[2] = abi.encodeWithSelector( | ||
| AccessManager.setTargetFunctionRole.selector, | ||
| pufferDeployment.moduleManager, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in AccessManager contract, one selector can be assigned to only one role for a target contract. so you can't assign both ROLE_ID_OPERATIONS_PAYMASTER and ROLE_ID_PUFFER_PROTOCOL role to triggerValidatorsExit function.
checkout AccessManager._setTargetFunctionRole function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either:
- grant both roles to the accounts - but this could be dangerous security wise
- or better create a new specific role and grant to both accounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added role ROLE_ID_VALIDATOR_EJECTOR. I used 28 instead of 27, because I used 27 in PR#136
This PR implements the flow to allow Puffer or the node operators to exit validators from the beacon chain with an on-chain transaction