add #1882
Closed
add #1882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend `VideoFrame.from_bytes` to all non-planar formats. Support for planar formats may be implemented in future. change default format to `rgb24` for consistency with other helper functions for frame creation.
adds support for gray formats: `gray9be`, `gray9le` `gray10be`, `gray10le` `gray12be`, `gray12le` `gray14be`, `gray14le` gbrp formats: `gbrp9be`, `gbrp9le`
default to `rgb24` format consistent with other functions
Member
|
Contribute to https://github.com/basswood-io/BasswoodAV instead |
Contributor
Author
|
reason? |
Member
|
Basswood-av is more up to date, and I'm tired of manually porting commits. |
Contributor
Author
|
okay, I'll resubmit soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add formats to
VideoFrame:gbrp9be,gbrp9legbrap10be,gbrap10le,gbrap12be,gbrap12le,gbrap14be,gbrap14le,gbrap16be,gbrap16legray9be,gray9le,gray10be,gray10le,gray12be,gray12le,gray14be,gray14leextend
VideoFrame.from_bytesto all non-planar formats and change default format fromrgbatorgb24for consistency.