emit deprecation on pyclasses that are affected by the FromPyObject blanket impl
#5550
+104
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This emits a deprecation warning on
#[pyclass]es that are affected by theFromPyObject + Cloneblanket impl. It uses aProbeto detect theCloneimpl and conditionally emits the deprecation. This ensures only types are flagged that are actually affected by the change. The deprecation can be suppressed by specifying either theskip_from_py_objectorfrom_py_objectoption.With this in 0.28, I think we can remove the blanket impl in 0.29.
#5419