Families module and test system big refactor #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiment
requested changes
Oct 13, 2025
| return parameters.transform_to_base_parametrization() | ||
|
|
||
| # Backward-compatibility helper (former ParametrizationSpec API) | ||
| def get_base_parameters(self, parameters: Parametrization) -> Parametrization: |
There was a problem hiding this comment.
I do not think that we need this method. We do not care about backward compatibility since we in pre-alpha stage of development
| """ | ||
| return self.to_base(parameters) | ||
|
|
||
| def build_analytical_computations( |
There was a problem hiding this comment.
Should this be public method?
There was a problem hiding this comment.
Strictly (two prefix underscores)? Definitely not. As a recommendation (single prefix underscores)? Quite yes, because Distribution uses it, but at the same time I would not like to show it to users.
# This is the 1st commit message: refactor: delete ParametrizationSpec # The commit message #2 will be skipped: # fixup! refactor: delete ParametrizationSpec
LeonidElkin
force-pushed
the
refactor/families-and-tests
branch
from
626b2c6 to
67f02ee
Compare
LeonidElkin
force-pushed
the
refactor/families-and-tests
branch
from
67f02ee to
764993b
Compare
LeonidElkin
force-pushed
the
refactor/families-and-tests
branch
from
764993b to
bc851e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<fam_obj_name>.parametrization(...)Parametrizationclass#type ...