Add support for the triangular lattice #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiggleLiu
reviewed
Jul 15, 2025
Comment on lines
+75
to
+76
| is_square_grid(g::GridGraph) = g.gridtype isa SquareGrid | ||
| is_triangular_grid(g::GridGraph) = g.gridtype isa TriangularGrid |
There was a problem hiding this comment.
Can we remove these two functions?
| print_grid(io, grid; show_weight=SHOW_WEIGHT[]) | ||
| end | ||
| Base.size(gg::GridGraph) = gg.size | ||
| Base.size(gg::GridGraph, i::Int) = gg.size[i] | ||
| function graph_and_weights(grid::GridGraph) | ||
| return unit_disk_graph(getfield.(grid.nodes, :loc), grid.radius), getfield.(grid.nodes, :weight) | ||
| if is_triangular_grid(grid) |
There was a problem hiding this comment.
use dispatch, e.g.
function graph_and_weights(grid::GridGraph{NT, <:SquareGrid})
function graph_and_weights(grid::GridGraph{NT, <:TriangularGrid}) where NT| return unit_disk_graph(getfield.(grid.nodes, :loc), grid.radius), getfield.(grid.nodes, :weight) | ||
| if is_triangular_grid(grid) | ||
| # For triangular grids, use physical positions | ||
| physical_locs = [physical_position(node) for node in grid.nodes] |
There was a problem hiding this comment.
You do not need to use dispatch, just implement the same physical_position interface for square lattice.
| return g | ||
| end | ||
|
|
||
| function physical_position(node, parity=false) |
There was a problem hiding this comment.
Implement the same function for square lattice.
| M = nrow*s+1+2*padding | ||
| u = fill(empty(mode isa Weighted ? MCell{Int} : MCell{ONE}), M, N) | ||
| s = get_spacing(mode) | ||
| N = (n-1)*s+2+2*padding |
| function mis_overhead_copyline(w::W, line::CopyLine) where W | ||
| if W === Weighted | ||
| s = 4 | ||
| function mis_overhead_copyline(w::W, line::CopyLine, s::Int=4) where W |
There was a problem hiding this comment.
Suggested change
| function mis_overhead_copyline(w::W, line::CopyLine, s::Int=4) where W | |
| function mis_overhead_copyline(w::W, line::CopyLine, s::Int) where W |
Do not use default parameter for low level API.
|
|
||
| # Get spacing value based on mode | ||
| get_spacing(::Union{UnWeighted, Weighted}) = 4 | ||
| get_spacing(::TriangularWeighted) = 14 |
There was a problem hiding this comment.
It is so big. Can we make it smaller, just use different spacing for X and Y axis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.