-
Notifications
You must be signed in to change notification settings - Fork 1
Emit source info as stim comments #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
That seems like the source information does not get propogate when rewrite Squin to Stim |
|
@kaihsin Please have a look at the latest commit. Now the source info is shown correctly for However, I'm not to happy with how I had to modify Additionally, source info is however lost in the If you agree, I will make a PR into kirin. |
|
Yes please create a PR on Kirin side - we wasn't being careful in handling these source info when creating the pass. |
|
With kirin/#541 source information is no longer discarded in the inline pass. However, this results in source info always pointing to stdlib functions. This means comments in stim code are not useful for debugging for debugging purposes. Instead #570 solves this by introducing debug statements. Cancelling this PR. |
…541) This PR ensures that source info is preserved after inlining or cloning in `.similar()`. Additionally I found that offsets were lost (which are now added in `lowering.py`). I tested all of these changes on kirin 0.17.30 together with bloqade-circuit. Blocks QuEraComputing/bloqade-circuit#552 Addresses #540
…541) This PR ensures that source info is preserved after inlining or cloning in `.similar()`. Additionally I found that offsets were lost (which are now added in `lowering.py`). I tested all of these changes on kirin 0.17.30 together with bloqade-circuit. Blocks QuEraComputing/bloqade-circuit#552 Addresses #540

With this PR, when
debug=TrueinEmitStimMain, output like this will now be emitted:I'm not fully sure if the source info is actually correct -- or if that's the format that is required. Open to feedback.