New Address Analysis. #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weinbe58
commented
Oct 27, 2025
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
david-pl
reviewed
Oct 28, 2025
Co-authored-by: David Plankensteiner <david-pl@users.noreply.github.com>
…omputing/bloqade-circuit into phil/new-address-analysis
david-pl
approved these changes
Oct 30, 2025
| case _: | ||
| return result | ||
|
|
||
| def unpack_iterable(self, collection: Address): |
There was a problem hiding this comment.
I guess, for consistency, this method should be called unpack_collection.
There was a problem hiding this comment.
I think I'm gonna rename it to iterable since in some cases it is an iterable in some cases its not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implement a Joint analysis with constant prop and Address analysis to try to get the address analysis to work properly going into the call stack.I do not use a Cartesian product for the lattic because I need to implement partial lambda and partial IList and tuple to get the analysis to work. In order to support constant folding, however, I opted into adding an extra lattice element to wrap the constant prop results.