-
Couldn't load subscription status.
- Fork 1
Get measure_id tests to work #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
@johnzl-777 that shouldn't happen, since Also, there was a test failing on Python 3.10, because somehow CSE didn't eliminate a line which threw off the line number of the results. I "fixed" that, by getting the results based on the variable names rather than the line number. |
Thank you so much for the fix! I guess I should have let CI run its course before going to bed last night ): As for the broadcast vs 1q measure I think the elimination problem was from the fact I was using a concrete boolean. The way around this is to just have a variable as a condition. And now that I've revisited this I realize that I CAN use |
This was pretty straightforward but the
scftests I had to rework a bit.There was a test where I use
squin.broadcast.measurein one branch of an scf.IfElse but the problem is that the passes/combination of passes I know to getqallocto cough up an IList with concrete length inevitably eliminate the scf.IfElse altogether.My workaround is to just use the 1Q measure which, funny enough, works but only because it immediately creates an IList with a concrete length the measure_id analysis can consume 😅