Skip to content

Conversation

@weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Oct 28, 2025

As we're introducing a large breaking change it is probably a good time to update the statements in native to be more consistent with squin's naming/call conventions.

blocked by CI at the moment.

@weinbe58 weinbe58 changed the title Fix Naming and argument conventions in native dialect. Kirin upgrade: fix Naming and argument conventions in native dialect. Oct 28, 2025
@weinbe58 weinbe58 changed the title Kirin upgrade: fix Naming and argument conventions in native dialect. Kirin upgrade: fix Naming and argument conventions in native.gate dialect. Oct 28, 2025
@weinbe58 weinbe58 changed the title Kirin upgrade: fix Naming and argument conventions in native.gate dialect. Kirin upgrade: fix naming and argument conventions in native.gate dialect. Oct 28, 2025
@david-pl
Copy link
Collaborator

@weinbe58 any reason this couldn't go into main directly to be released with the squin refactor?

@weinbe58 weinbe58 force-pushed the phil/rename-dialects-native branch from 7bdbfcc to 78f5d2b Compare October 29, 2025 16:48
@weinbe58 weinbe58 changed the base branch from david/571-kirin-upgrade-branch to main October 29, 2025 16:49
@weinbe58 weinbe58 requested a review from david-pl October 29, 2025 16:49
@david-pl
Copy link
Collaborator

@weinbe58 eh, CI is not happy with the branch. Honestly it may be easier to just start off of main and redo the changes. Or we can leave it for v0.9 together with the kirin upgrade if it's too much of a hassle.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/native/stdlib/broadcast.py 25.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9508 8398 88% 0% 🟢

New Files

File Coverage Status
src/bloqade/native/dialects/gate/_dialect.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/bloqade/native/_prelude.py 100% 🟢
src/bloqade/native/stdlib/broadcast.py 63% 🟢
src/bloqade/pyqrack/native.py 100% 🟢
TOTAL 88% 🟢

updated for commit: 4b35f8a by action🐍

@weinbe58
Copy link
Member Author

@weinbe58 eh, CI is not happy with the branch. Honestly it may be easier to just start off of main and redo the changes. Or we can leave it for v0.9 together with the kirin upgrade if it's too much of a hassle.

should be all set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants