Skip to content

Conversation

@leburgel
Copy link
Member

Adds the symmetric tensor tutorial from the quantumghent tensor tutorials to the docs as an appendix, as discussed in #289.

In the process, I add subblock and subblocks to the library docs, since these were missing before so I couldn't reference their docstrings.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

After the build completes, the updated documentation will be available here

@leburgel
Copy link
Member Author

Not really the main point here, but I would also prefer it if all toc depths in docs/src/index.md were set to 2. I've always thought the depth-3 ones look very busy.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try and go through in more detail, some small comments:

It might make the notation a bit lighter if we replace ComplexF64 with Float64 for the cases where this is applicable, I know we don't default to this in MPSKit for various reasons, but here it seems a bit much to me.

For git reasons it might be convenient to break lines at sentences instead of splitting at linewidth. It also tends to make paragraphs less jumpy for small changes/comments

@leburgel leburgel requested review from Jutho and lkdvos November 19, 2025 13:42
Jutho
Jutho previously approved these changes Nov 25, 2025
Copy link
Member

@Jutho Jutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial. I left some minor comments and suggestions.

Co-authored-by: Jutho <Jutho@users.noreply.github.com>
lkdvos
lkdvos previously approved these changes Nov 28, 2025
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some final comments but otherwise definitely good to go for me. Great work, thank you!

Co-authored-by: Lukas Devos <ldevos98@gmail.com>
@leburgel leburgel requested review from Jutho and lkdvos December 1, 2025 09:36
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
@Jutho
Copy link
Member

Jutho commented Dec 1, 2025

Ok, I think these are the final suggestions. If these are addressed, I will approve and merge.

@Jutho Jutho merged commit 318f921 into main Dec 1, 2025
39 of 42 checks passed
@Jutho Jutho deleted the lb/add_tutorial branch December 1, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants