-
Notifications
You must be signed in to change notification settings - Fork 56
Add symmetric tensor tutorial to docs as appendix #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
After the build completes, the updated documentation will be available here |
|
Not really the main point here, but I would also prefer it if all toc depths in |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try and go through in more detail, some small comments:
It might make the notation a bit lighter if we replace ComplexF64 with Float64 for the cases where this is applicable, I know we don't default to this in MPSKit for various reasons, but here it seems a bit much to me.
For git reasons it might be convenient to break lines at sentences instead of splitting at linewidth. It also tends to make paragraphs less jumpy for small changes/comments
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Jutho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial. I left some minor comments and suggestions.
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Co-authored-by: Boris De Vos <143942306+borisdevos@users.noreply.github.com>
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some final comments but otherwise definitely good to go for me. Great work, thank you!
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
…ch-Gordan decomposition
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
|
Ok, I think these are the final suggestions. If these are addressed, I will approve and merge. |
Adds the symmetric tensor tutorial from the quantumghent tensor tutorials to the docs as an appendix, as discussed in #289.
In the process, I add
subblockandsubblocksto the library docs, since these were missing before so I couldn't reference their docstrings.