Python3 Subscriber fix #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poller Loop Bug
Commit c48fc29
Fixed bug in poller loop in origin_subscriber.py. The poller loop referenced local variable
stream_filterbut did not always set it. The only place wherestream_filterwas set was in the command actionSUBSCRIBE. This caused the command actionUNSUBSCRIBEto use the wrong value forstream_filterbecause it was only set inSUBSCRIBEaction. This was fixed by removing the local variablestream_filterand instead using the variable directly from the command.Keyboard Interrupt Handling
Commit 10f0dff
origin_subscriber.py and receiver.py did not handle
KeyboardInterruptwell. The subscriber now does not throw unnecessaryKeyboardInterrupterrors when stopping the program in the poller loop. Also, subscriber is now able to be stopped if it can't initially connect to the Origin server instead of being stuck in a loop.