Skip to content

bounds checking in apply! #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

bounds checking in apply! #571

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3c602f
Check stabilizer bounds for single and two qubit operators
Oct0bass Aug 4, 2025
8733c0e
Merge branch 'QuantumSavory:master' into qubit-op-bounds-check
Oct0bass Aug 4, 2025
ed2e2b7
use new standardized throw messages
Oct0bass Aug 4, 2025
53e4213
add checks to _apply_inv!
Oct0bass Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/symbolic_cliffords.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Base.@propagate_inbounds setzbit(xzs::AbstractMatrix{T}, r::Int, c::Int, z::T, s
function _apply!(stab::AbstractStabilizer, gate::AbstractSingleQubitOperator; phases::Val{B}=Val(true)) where {B}
s = tab(stab)
c = gate.q
@boundscheck c <= nqubits(stab) || throw(THROW_BOUNDS)
@inbounds @simd for r in eachindex(s)
x = getxbit(s, r, c)
z = getzbit(s, r, c)
Expand All @@ -74,6 +75,7 @@ end
function _apply_inv!(stab::AbstractStabilizer, gate::AbstractSingleQubitOperator; phases::Val{B}=Val(true)) where {B} # code repetition with the corresponding `_apply`
s = tab(stab)
c = gate.q
@boundscheck c <= nqubits(stab) || throw(THROW_BOUNDS)
@inbounds @simd for r in eachindex(s)
x = getxbit(s, r, c)
z = getzbit(s, r, c)
Expand Down Expand Up @@ -176,6 +178,7 @@ end
function _apply!(stab::AbstractStabilizer, op::SingleQubitOperator; phases::Val{B}=Val(true)) where B # TODO Generated functions that simplify the whole `if phases` branch might be a good optimization, but a quick benchmakr comparing sHadamard to SingleQubitOperator(sHadamard) did not show a worthwhile difference.
s = tab(stab)
c = op.q
@boundscheck c <= nqubits(stab) || throw(THROW_BOUNDS)
Tₘₑ = eltype(s.xzs)
sh = getshift(Tₘₑ, c)
xx,zx,xz,zz = Tₘₑ.((op.xx,op.zx,op.xz,op.zz)) .<< sh
Expand Down Expand Up @@ -292,6 +295,7 @@ function _apply!(stab::AbstractStabilizer, gate::AbstractTwoQubitOperator; phase
s = tab(stab)
q1 = gate.q1
q2 = gate.q2
@boundscheck max(q1, q2) <= nqubits(stab) || throw(THROW_BOUNDS)
Tₘₑ = eltype(s.xzs)
shift = getshift(Tₘₑ, q1) - getshift(Tₘₑ, q2)
@inbounds @simd for r in eachindex(s)
Expand All @@ -317,6 +321,7 @@ function _apply_inv!(stab::AbstractStabilizer, gate::AbstractTwoQubitOperator; p
s = tab(stab)
q1 = gate.q1
q2 = gate.q2
@boundscheck max(q1, q2) <= nqubits(stab) || throw(THROW_BOUNDS)
Tₘₑ = eltype(s.xzs)
shift = getshift(Tₘₑ, q1) - getshift(Tₘₑ, q2)
@inbounds @simd for r in eachindex(s)
Expand Down
Loading