correctness tests for classical ECCs #588
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fe-r-oz
force-pushed
the
fa/automated_cecc_tests
branch
3 times, most recently
from
3fe8b69 to
28ea18b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
- Coverage 85.09% 76.78% -8.32%
==========================================
Files 122 121 -1
Lines 7362 7349 -13
==========================================
- Hits 6265 5643 -622
- Misses 1097 1706 +609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fe-r-oz
added
the
Skip-Changelog
Fe-r-oz
force-pushed
the
fa/automated_cecc_tests
branch
from
28ea18b to
60b9796
Compare
Fe-r-oz
commented
Sep 16, 2025
Comment on lines
+52
to
+73
| function all_testable_classical_code_instances(;maxn=nothing) | ||
| types = subtypes(AbstractCECC) | ||
| concrete = Type[] | ||
| while !isempty(types) | ||
| t = popfirst!(types) | ||
| isabstracttype(t) ? append!(types, subtypes(t)) : push!(concrete, t) | ||
| end | ||
| codeinstances = [] | ||
| for t in concrete | ||
| t_name = Symbol(split(string(t), ".")[end]) | ||
| for args in get(classical_code_instance_args, t_name, []) | ||
| try | ||
| codeinstance = t(args...) | ||
| !isnothing(maxn) && code_n(codeinstance) > maxn && continue | ||
| push!(codeinstances, codeinstance) | ||
| catch e | ||
| @warn "Failed to create $t with args $args: $e" | ||
| end | ||
| end | ||
| end | ||
| return codeinstances | ||
| end |
There was a problem hiding this comment.
I will improve this so it also check with pop that all the codes are tests and simplify this similar to what is done for QECCs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the automated tests for the classical ECCs by creating the
test_cecc_base.jlthat has all the classical ECCs instances which are then utilized in thetest_cecc.jlto test the general properties of the parity check matrices of the classical error correcting codes. This resolves #268