Skip to content

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Sep 21, 2025

This PR implements bivariate bicycle code using polynomial quotient ring and resolves #596. Three-term, four-term and n-term bivariate polynomials are supported.

[[756, 16, ≤ 34]]

julia> l=21; m=18;
julia> R, (x, y) = polynomial_ring(GF(2), [:x, :y]);
julia> I = ideal(R, [x^l-1, y^m-1]);
julia> S, _ = quo(R, I);
julia> A = S(x^3 + y^10 + y^17);
julia> B = S(y^5 + x^3  + x^19);
julia> c = BivariateBicycleCode(l, m, A, B);
julia> code_n(c), code_k(c)
(756, 16)

[[128, 14, 12]]

julia> l=8; m=8;
julia> R, (x, y) = polynomial_ring(GF(2), [:x, :y]);
julia> I = ideal(R, [x^l-1, y^m-1]);
julia> S, _ = quo(R, I);
julia> A = S(x^2 + y + y^3 + y^4);
julia> B = S(y^2 + x + x^3 + x^4);
julia> c = BivariateBicycleCode(l, m, A, B);
julia> code_n(c), code_k(c)
(128, 14)
  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them

@Fe-r-oz Fe-r-oz force-pushed the fa/BB-using-quotient-ring branch from d312a37 to 7a457c6 Compare September 21, 2025 01:42
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.73%. Comparing base (73c133a) to head (5508616).

Files with missing lines Patch % Lines
src/ecc/codes/qeccs_using_oscar.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   76.53%   76.73%   +0.20%     
==========================================
  Files         122      123       +1     
  Lines        7491     7545      +54     
==========================================
+ Hits         5733     5790      +57     
+ Misses       1758     1755       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fe-r-oz Fe-r-oz force-pushed the fa/BB-using-quotient-ring branch from 7a457c6 to 3d88013 Compare September 21, 2025 23:44
@Fe-r-oz Fe-r-oz marked this pull request as ready for review September 24, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bivariate bicycle code using polynomial quotient ring
1 participant