-
Notifications
You must be signed in to change notification settings - Fork 4
Add functioa #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functioa #42
Conversation
…uration Simplify the global CSS and Tailwind configuration by removing unused variables and consolidating theme-related settings. This improves maintainability and reduces redundancy in the codebase.
The host, port, and allowedHosts configurations were removed from the dev server settings to simplify the configuration and rely on Vite's default behavior. This change reduces unnecessary customization and aligns with standard Vite practices.
Text dark and light
- Add theme script for initial theme detection and application - Update global.css with theme variables and dark mode selector - Refactor ThemeToggle component to use localStorage for theme persistence - Modify vite config to handle build-specific alias configuration - Add type definitions path to package.json ``` The commit message follows the guidelines by: 1. Using "feat" type since it introduces new theme functionality 2. Including "(theme)" scope as it's clearly theme-related 3. Keeping description under 50 chars and starting with lowercase 4. Adding a body that summarizes the key changes without repeating the subject 5. Using imperative mood throughout 6. Focusing on the significant functional changes rather than every detail
- Normalize quotes from single to double quotes - Fix missing semicolons and newlines - Reorder tailwind classes consistently - Remove unused useDark hook - Update theme script to be more reliable - Apply prettier formatting across the codebase
- Remove ThemeScript component and inline theme script logic in devtools - Remove unused useDark hook from ThemeToggle - Simplify theme toggle logic by removing dark state check
…ity condition - Remove unused ThemeScript import to clean up dependencies - Fix devtools panel visibility to only show when state.isOpen.value is true
Update all double quotes to single quotes across the codebase for consistency. Added 'singleQuote: true' to prettier configuration to enforce this style. This change improves code style consistency and aligns with the project's linting rules.
- Rename theme storage key for compatibility with vite-plugin-inspect - Extract theme script logic into separate component - Remove unused imports and simplify ThemeToggle component - Replace inline script with ThemeScript component in devtools
- Add 'auto' theme option that follows system preference - Replace button with select dropdown for theme selection - Improve theme script to handle auto theme case - Fix extra space in search input styling
…pgrade rollup to 4.41.1, and update peer dependencies
|
…ing and rendering logic
…de, and RenderTree components
…and RenderTree components
…nt, rendering logic, and new signal handling capabilities
…dling, state management, and improved tree node creation logic
…d improved styling; update RenderTree and filterVnode for better state handling and type detection
…; enhance devtools integration in playgrounds and improve code consistency across components
…signal, task, and computed data handling; refactor vnode and filterVnode for better code clarity
…over state management; refactor formatTreeData to improve data handling and naming consistency
… data handling; update type utilities for better type detection
…odule retrieval capabilities; update .gitignore and Vite configuration for improved development experience
…ved module retrieval; refactor RenderTree and formatTreeData for enhanced data handling and integration with new module fetching logic
…proving hook usage; streamline context and resource handling for better readability
… type map for improved data formatting and clarity; enhance props processing for better readability
… and maintainability
… and maintainability
…n statement and optimizing JSX structure for improved readability
…; enhance code rendering with dynamic language detection and improved styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments but overall LGTM!
👍
…ach with for...of loop for improved performance and readability
…conventions and improve tree node creation logic; enhance signal and task handling for better clarity
@JerryWu1234 thanks! @gioboa next time if there are a lot of commits (and not one commit per meaningful change) we can squash the commit and that will keep the git history cleaner. Thanks again for working on this! can't wait to see the end result of the devtools 🙌 |
yep, you are right. I squashed it 💪 ![]() |
@gioboa sorry for some reason I missed it, thank you very much! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem at all 👍
Uh oh!
There was an error while loading. Please reload this page.