Skip to content

Conversation

@GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Jul 18, 2023

We need some way for user to change their setup to packages I'm too time limited to get a proper UI and everything so I propose we hijack our existing update prompt for mods to achieve this.

Simply put:

  • Give an outdated version number on legacy installed Thunderstore mods (I'm using 0.0.0 for this which is not available on Thunderstore)
  • User has the option to "update mod"
  • Adjust our update mechanism so that it also removes legacy versions of installed mods on successful update.

TODO:

Part of #415

@GeckoEidechse GeckoEidechse marked this pull request as draft July 18, 2023 13:25
@GeckoEidechse GeckoEidechse mentioned this pull request Jul 18, 2023
@GeckoEidechse GeckoEidechse marked this pull request as ready for review July 21, 2023 14:59
@GeckoEidechse
Copy link
Member Author

There might be a better mechanism to do this, other than pretending mod is outdated.

Also I'm pretty sure having multiple mods outdated and spam clicking them to update causes some issues (at least based on past experience where install would then fail sometimes). So if we go with this approach we might wanna have an "update all" option or a way to block installing/updating another mod while current one is being installed.

@GeckoEidechse GeckoEidechse requested a review from Alystrasz July 21, 2023 16:30
@Alystrasz
Copy link
Collaborator

Give an outdated version number on legacy installed Thunderstore mods (I'm using 0.0.0 for this which is not available on Thunderstore)

If it works, it ain't stupid, right?

or a way to block installing/updating another mod while current one is being installed.

Another issue for another day 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants