Skip to content

Conversation

@sbekkerm
Copy link
Contributor

Switched to uv for dependency management to leverage performance gains over PDM

@EmilienM EmilienM requested a review from lpiwowar May 21, 2025 19:05
@EmilienM
Copy link
Contributor

I'm fine with it, but I'll leave the decision to @lpiwowar

Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 just one small question and then it is good to merge IMO.

I personally prefer uv over pdm. I think we picked up pdm because that's the package manager that the lightspeed-core project seems to follow. So we just stuck with it.

Btw, pdm supports using uv as a backend (experimental feature). It makes the installation faster. Even though it is a bit strange (using one package manager as a backend for another package manager 🙃).

Also, it is going to be interesting how both pdm and uv will deal with the now relatively freshly accepted pylock.toml (PEP-751). From what I heard, uv will support it, but it will stick by default to its own format uv.lock, and pdm aims to make pylock.toml its default format.

@lpiwowar lpiwowar self-requested a review May 26, 2025 09:24
@lpiwowar lpiwowar merged commit cce7a0d into main May 26, 2025
4 checks passed
@lpiwowar lpiwowar deleted the uv branch May 26, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants