-
Notifications
You must be signed in to change notification settings - Fork 45
Bump 2.2.1 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 2.2.1 #87
Conversation
Remove Gazebo simulation package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on bumping the version of the TurtleBot3 Manipulation packages to 2.2.1. The most significant functional change is the complete removal of the Gazebo simulation environment and its associated components and dependencies. Additionally, there are numerous minor code style and formatting improvements across various launch and source files.
Highlights
- Version Bump: The version number has been updated to 2.2.1 across all
turtlebot3_manipulation
related packages. - Gazebo Simulation Removal: The Gazebo simulation environment for the TurtleBot3 Manipulation has been removed, including related files, dependencies (
gazebo_ros
,gripper_controllers
,warehouse_ros_mongo
), and installation targets. - Code Formatting and Imports: Various Python launch files and C++ source/header files received minor formatting updates (e.g., double quotes to single quotes) and import reordering.
- MoveIt Configuration Updates: The MoveIt RViz configuration file (
moveit.rviz
) has the warehouse host and port commented out. Minor formatting adjustments were made in several MoveIt launch files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily bumps the package versions to 2.2.1. Key changes include the removal of TurtleBot3 Manipulation Gazebo simulation support, evidenced by updates in changelogs, CMakeLists (removal of worlds
directory), and package.xml files (removal of gazebo_ros
dependency).
Additionally, the MoveIt warehouse integration via warehouse_ros_mongo
seems to have been disabled, as seen by changes in RViz configuration and package dependencies.
Numerous Python and C++ files have undergone stylistic changes, such as consistent use of single quotes in Python, import reordering, and code formatting. These changes generally align with common best practices (e.g., PEP 8 for Python, common C++ formatting conventions) and improve code consistency and readability.
One point for consideration is the removal of an explicit dependency on gripper_controllers
in turtlebot3_manipulation_bringup/package.xml
, which is detailed in a specific comment.
Uh oh!
There was an error while loading. Please reload this page.