Audio support - Replace Audio QA samples #616

r-abishek · 2025-09-18T23:21:45Z

This is a audio test suite QA PR to:

Replace input audio samples with the new MIVisionX-data samples.
Regenerate golden outputs for all RPP audio functionality.
Modify the input params to match the new input audio-sample dimensions.

Audio QA with New Audio Input Samples

Copilot

Pull Request Overview

This PR updates the audio test suite to support new MIVisionX-data samples by replacing input audio samples and regenerating golden outputs for RPP audio functionality. The changes include updating input parameters to match new audio sample dimensions and standardizing buffer calculations.

Replace hardcoded buffer sizes with defined constants for better maintainability
Update golden output values for Non Silent Region Detection to match new audio samples
Modify input parameters (dimensions, sample rates) to align with new test dataset
Standardize error return codes across HOST and HIP implementations

Reviewed Changes

Copilot reviewed 3 out of 17 changed files in this pull request and generated 1 comment.

File	Description
utilities/test_suite/rpp_test_suite_audio.h	Defines new constants and updates golden output values for new audio samples
utilities/test_suite/HOST/Tensor_audio_host.cpp	Updates buffer calculations, sample rates, and tensor dimensions for new dataset
utilities/test_suite/HIP/Tensor_audio_hip.cpp	Applies similar updates to HIP implementation with consistent changes

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

utilities/test_suite/HIP/Tensor_audio_hip.cpp

codecov · 2025-09-19T21:55:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #616      +/-   ##
===========================================
- Coverage    88.39%   88.38%   -0.01%     
===========================================
  Files          195      195              
  Lines        82768    82768              
===========================================
- Hits         73156    73148       -8     
- Misses        9612     9620       +8

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

utilities/test_suite/HIP/Tensor_audio_hip.cpp

rrawther · 2025-09-23T15:42:22Z

utilities/test_suite/HOST/Tensor_audio_host.cpp

        descriptorPtr3D->dataType = RpptDataType::F32;
        descriptorPtr3D->dims[0] = batchSize;
-        descriptorPtr3D->dims[1] = maxSrcWidth;
+        descriptorPtr3D->dims[1] = (maxSrcWidth / 8) * 8 + 8; // Ensure a consistent dimension order between generic and typed descriptors to prevent errors.


Not sure why this is needed?

this was to ensure descriptor dims[1] is maxSrcWidth or higher, but a multiple of 8 for vectorized versions

then (maxSrcWidth + 8) & ^7 would be better and more efficient

rrawther

Please address review comments

rrawther · 2025-09-23T15:42:45Z

utilities/test_suite/HOST/Tensor_audio_host.cpp

    {
-        iBufferSize = (Rpp64u)MEL_FILTER_BANK_MAX_HEIGHT * (Rpp64u)srcDescPtr->w * (Rpp64u)srcDescPtr->c * (Rpp64u)srcDescPtr->n;
-        oBufferSize = (Rpp64u)MEL_FILTER_BANK_MAX_HEIGHT * (Rpp64u)dstDescPtr->w * (Rpp64u)dstDescPtr->c * (Rpp64u)dstDescPtr->n;
+        iBufferSize = (Rpp64u)AUDIO_MAX_HEIGHT * (Rpp64u)srcDescPtr->w * (Rpp64u)srcDescPtr->c * (Rpp64u)srcDescPtr->n;


I think MEL_FILTER_BANK_MAX_HEIGHT is better name here

rrawther · 2025-09-23T15:51:42Z

utilities/test_suite/HOST/Tensor_audio_host.cpp

-                        inRateTensor[i] = 16000;
-                        outRateTensor[i] = 16000 * 1.15f;
+                        inRateTensor[i] = 44100;
+                        outRateTensor[i] = 44100 * 1.15f;


what is 1.15 stand for? Please write comment and use ENUM. I think we need to take sample_rate as a parameter instead of hardcoding

All these have been changed to #defines -> SAMPLE_RATE * RESAMPLE_BUFFER_SCALE_FACTOR

rrawther · 2025-09-23T15:53:51Z

utilities/test_suite/rpp_test_suite_audio.h

-    {"sample1", {0, 35840}},
-    {"sample2", {0, 33680}},
-    {"sample3", {0, 34160}}
+    {"sample1", {0, 507150}},


what is this hardcoded numbers stand for. If this depends on the input. we need to extract it from there or user has to provide

these are now removed

…access QA golden output from bin files

…size calculation

AUDIO Support - Fix Copilot comments

rrawther · 2025-10-03T21:05:54Z

utilities/test_suite/HIP/Tensor_audio_hip.cpp

                    {
-                        inRateTensor[i] = 16000;
-                        outRateTensor[i] = 16000 * 1.15f;
+                        inRateTensor[i] = SAMPLE_RATE;


can we take these as parameters instead? What if a user want to use different audio samples with different sample_rate and scale_factor

rrawther

added few more comments

Audio QA support - review comments resolved

rrawther

Added a comment

Audio QA PR: Review comments resolution

HazarathKumarM and others added 6 commits September 4, 2025 06:43

Modified single, multi channel audio and generated QA

aa8c918

Added QA support for other kernels

a353c5c

Updated bin files for QA

f76df76

Updated and modified slice bin file for QA

9e79dba

Resolved review comments and made modifications to the parameters

41be482

Merge pull request #489 from HazarathKumarM/audio_qa

6b013c5

Audio QA with New Audio Input Samples

r-abishek requested a review from Copilot September 18, 2025 23:21

r-abishek added the ci:precheckin label Sep 18, 2025

Copilot AI reviewed Sep 18, 2025

View reviewed changes

utilities/test_suite/HIP/Tensor_audio_hip.cpp Outdated Show resolved Hide resolved

kiritigowda self-assigned this Sep 22, 2025

kiritigowda requested a review from rrawther September 22, 2025 17:28

kiritigowda and others added 3 commits September 22, 2025 10:30

Merge branch 'develop' into ar/audio_support_qa_samples

55c1d70

Merge branch 'develop' into ar/audio_support_qa_samples

8493196

Modified parameters, updated the names and output docs image

f204c17

rrawther reviewed Sep 23, 2025

View reviewed changes

utilities/test_suite/HIP/Tensor_audio_hip.cpp Outdated Show resolved Hide resolved

rrawther reviewed Sep 23, 2025

View reviewed changes

utilities/test_suite/HIP/Tensor_audio_hip.cpp Show resolved Hide resolved

rrawther reviewed Sep 23, 2025

View reviewed changes

rrawther requested changes Sep 23, 2025

View reviewed changes

kiritigowda and others added 8 commits September 23, 2025 16:01

Merge branch 'develop' into ar/audio_support_qa_samples

b97acd3

Merge branch 'develop' into ar/audio_support_qa_samples

8524127

Resolved review comments and modified non silent region detection to …

144d02a

…access QA golden output from bin files

Modified and used oBufferSize as base directly to the resampleBuffer …

c1a69c7

…size calculation

Updated compare function for non silent region

c3cc332

Merge pull request #498 from HazarathKumarM/audio_qa

881fcda

AUDIO Support - Fix Copilot comments

Merge branch 'develop' into ar/audio_support_qa_samples

53d9900

Merge branch 'develop' into ar/audio_support_qa_samples

a7ab6c9

rrawther reviewed Oct 3, 2025

View reviewed changes

rrawther requested changes Oct 3, 2025

View reviewed changes

Resolved review comments

79d444c

r-abishek added 2 commits October 7, 2025 22:45

Merge pull request #502 from HazarathKumarM/audio_qa

1da1b76

Audio QA support - review comments resolved

Merge branch 'develop' into ar/audio_support_qa_samples

be98209

rrawther requested changes Oct 9, 2025

View reviewed changes

kiritigowda and others added 5 commits October 10, 2025 14:41

Merge branch 'develop' into ar/audio_support_qa_samples

a28ebf8

Updated comments for mel filter bank

7603629

Updated comments for resample

81b53c5

Merge pull request #506 from HazarathKumarM/audio_qa

c8cc526

Audio QA PR: Review comments resolution

Merge branch 'develop' into ar/audio_support_qa_samples

1cd4531

Audio support - Replace Audio QA samples #616

Are you sure you want to change the base?

Audio support - Replace Audio QA samples #616

Conversation

r-abishek commented Sep 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rrawther Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 19, 2025 •

edited

Loading

rrawther Oct 3, 2025 •

edited

Loading