Skip to content

Conversation

@wdfk-prog
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在使用 Finsh/MSH 的 list_thread 命令查看线程状态时,用于显示栈使用率的格式化字符串是 %02d。这个格式化方式只能正确处理两位数(0-99)的百分比。当某个线程的栈使用率恰好为100%时,会导致显示异常,破坏了输出的对齐格式,降低了调试信息的可读性。

你的解决方案是什么 (what is your solution)

为了解决这个问题,本 PR 将 rt_kprintf 中用于打印栈使用率的格式化字符串从 %02d 修改为 %3d。
这个简单的改动可以确保:

  1. 当栈使用率为100%时,能够被完整且正确地显示。
  2. 对于低于100%的数值,会使用空格进行左填充,从而保证了整个“栈使用率”列的输出始终对齐,提升了 list_thread 命令输出的美观性和可读性。
  • 修复前效果
[2025/11/5 11:39:18 820] thread             pri  status      sp     stack size max used left tick   error  tcb addr   usage
[2025/11/5 11:39:18 820] ------------------ ---  ------- ---------- ----------  ------  ---------- ------- ---------- -----
[2025/11/5 11:39:18 820] isotp_client        22  suspend 0x000001ac 0x00000800    58%   0x00000008 EINTRPT 0x200167f8   0%
[2025/11/5 11:39:18 820] isotp_logger        23  running 0x0000010c 0x00000400    100%   0x00000009 OK      0x20016328   0%
[2025/11/5 11:39:18 820] isotp_server        22  suspend 0x000002c4 0x00000800    69%   0x00000006 OK      0x2000a5f0   0%
[2025/11/5 11:39:18 820] isotp_consumer      15  suspend 0x000000dc 0x00000800    19%   0x00000009 EINTRPT 0x20009c20   0%
  • 修复后效果
[2025/11/5 11:50:48 399] thread             pri  status      sp     stack size max used left tick   error  tcb addr   usage
[2025/11/5 11:50:48 399] ------------------ ---  ------- ---------- ----------  ------  ---------- ------- ---------- -----
[2025/11/5 11:50:48 399] isotp_client        22  suspend 0x000001ac 0x00000800     58%   0x00000008 EINTRPT 0x200167d8   0%
[2025/11/5 11:50:48 399] isotp_logger        23  running 0x0000010c 0x00000400    100%   0x00000009 OK      0x20016308   0%
[2025/11/5 11:50:48 399] isotp_server        22  suspend 0x000002dc 0x00000800     69%   0x00000006 OK      0x2000a610   0%
[2025/11/5 11:50:48 399] isotp_consumer      15  suspend 0x000000dc 0x00000800     19%   0x00000008 EINTRPT 0x20009c40   0%

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/finsh/cmd.c

📊 Current Review Status (Last Updated: 2025-11-05 16:13 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:list_thread
  • 设置PR number为 \ Set the PR number to:10897
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 list_thread 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the list_thread branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@Rbb666 Rbb666 merged commit 55306ad into RT-Thread:master Nov 6, 2025
58 checks passed
@wdfk-prog wdfk-prog deleted the list_thread branch November 7, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants