Skip to content

Conversation

@ChuanN-sudo
Copy link

@ChuanN-sudo ChuanN-sudo commented Nov 10, 2025

Continue from #10885
增加了对于spi和qspi两种调用方式的支持,在utest里增加了相关测试demo;
kconfig中从qspi改为spi,增添了对于时钟速度和支持模式的说明;
按照 #10885的comment提到的改动建议进行了修改

Requirement: The BSP for the k230 platform in the RT-Thread repository does not yet have an spi driver.

Solution: Provide spi driver for the k230 platform in the RT-Thread repository.

-Supports SPI0(OSPI) controller with 1/2/4/8 data lines.
-Supports SPI1(QSPI0) and SPI2(QSPI1) controllers with 1/2/4 data lines.
-Implements DMA-based transfers for OSPI, QSPI, and DSPI modes.
-Falls back to standard IRQ-driven transfers for legacy SPI mode (single line).
-Driver support for input SPI-related structures and QSPI-related structures.

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

为K230添加spi驱动

你的解决方案是什么 (what is your solution)

添加spi驱动

请提供验证的bsp和config (provide the config and bsp)

  • BSP:/bsp/k230/drivers/interdrv/spi

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:k230_spi_driver
  • 设置PR number为 \ Set the PR number to:10917
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 k230_spi_driver 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the k230_spi_driver branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added the BSP label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_k230

Reviewers: unicornx

Changed Files (Click to expand)
  • bsp/k230/.ci/attachconfig/ci.attachconfig.yml
  • bsp/k230/.config
  • bsp/k230/board/Kconfig
  • bsp/k230/drivers/interdrv/spi/SConscript
  • bsp/k230/drivers/interdrv/spi/drv_spi.c
  • bsp/k230/drivers/interdrv/spi/drv_spi.h
  • bsp/k230/drivers/utest/SConscript
  • bsp/k230/drivers/utest/test_spi.c
  • bsp/k230/rtconfig.h

📊 Current Review Status (Last Updated: 2025-11-11 11:31 CST)

  • unicornx Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666 Rbb666 requested review from Copilot and unicornx November 11, 2025 02:35
Copilot finished reviewing on behalf of Rbb666 November 11, 2025 02:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds SPI driver support for the K230 platform, providing the capability to use SPI0 (OSPI), SPI1 (QSPI0), and SPI2 (QSPI1) controllers. The driver supports both standard SPI and QSPI modes with 1/2/4/8 data lines, implements DMA-based transfers for multi-line modes, and falls back to IRQ-driven transfers for legacy single-line SPI mode.

Key Changes:

  • New SPI driver implementation supporting multiple data line configurations (1/2/4/8 lines)
  • DMA-based transfer support for high-speed multi-line modes
  • IRQ-driven transfer fallback for standard SPI mode
  • Support for both rt_spi_device and rt_qspi_device structures

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
bsp/k230/drivers/interdrv/spi/drv_spi.c Core SPI driver implementation with configure, transfer, and IRQ handling functions
bsp/k230/drivers/interdrv/spi/drv_spi.h SPI register definitions and hardware configuration macros
bsp/k230/drivers/utest/test_spi.c Unit tests demonstrating both SPI and QSPI device usage
bsp/k230/board/Kconfig Configuration options for enabling SPI0/SPI1/SPI2 controllers
bsp/k230/drivers/utest/SConscript Build script integration for SPI test cases
bsp/k230/.ci/attachconfig/ci.attachconfig.yml CI configuration for SPI testing
bsp/k230/.config Updated configuration file with new package options
bsp/k230/rtconfig.h Added HPMicro SDK section

Requirement: The BSP for the k230 platform in the RT-Thread repository does not yet have an spi driver.

Solution: Provide spi driver for the k230 platform in the RT-Thread repository.

-Supports SPI0(OSPI) controller with 1/2/4/8 data lines.
-Supports SPI1(QSPI0) and SPI2(QSPI1) controllers with 1/2/4 data lines.
-Implements DMA-based transfers for OSPI, QSPI, and DSPI modes.
-Falls back to standard IRQ-driven transfers for legacy SPI mode (single line).
—Driver support for input SPI-related structures and QSPI-related structures.

Signed-off-by: ChuanN-sudo <fjchuanil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant