Skip to content

Allow thread=None in Webhook.send() #10314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow thread=None in Webhook.send() #10314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f9123
Allow thread=None in Webhook.send()
LeviPesin Sep 21, 2025
9c5fb23
Same for SyncWebhook
LeviPesin Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions discord/webhook/async_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,7 @@ async def send(
) as params:
adapter = async_context.get()
thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

data = await adapter.execute_webhook(
Expand Down Expand Up @@ -1959,7 +1959,7 @@ async def fetch_message(self, id: int, /, *, thread: Snowflake = MISSING) -> Web
raise ValueError('This webhook does not have a token associated with it')

thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

adapter = async_context.get()
Expand Down Expand Up @@ -2102,7 +2102,7 @@ async def edit_message(
previous_allowed_mentions=previous_mentions,
) as params:
thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

adapter = async_context.get()
Expand Down Expand Up @@ -2164,7 +2164,7 @@ async def delete_message(self, message_id: int, /, *, thread: Snowflake = MISSIN
raise ValueError('This webhook does not have a token associated with it')

thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

adapter = async_context.get()
Expand Down
8 changes: 4 additions & 4 deletions discord/webhook/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,7 @@ def send(
) as params:
adapter: WebhookAdapter = _get_webhook_adapter()
thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

data = adapter.execute_webhook(
Expand Down Expand Up @@ -1166,7 +1166,7 @@ def fetch_message(self, id: int, /, *, thread: Snowflake = MISSING) -> SyncWebho
raise ValueError('This webhook does not have a token associated with it')

thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

adapter: WebhookAdapter = _get_webhook_adapter()
Expand Down Expand Up @@ -1280,7 +1280,7 @@ def edit_message(
previous_allowed_mentions=previous_mentions,
) as params:
thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

adapter: WebhookAdapter = _get_webhook_adapter()
Expand Down Expand Up @@ -1326,7 +1326,7 @@ def delete_message(self, message_id: int, /, *, thread: Snowflake = MISSING) ->
raise ValueError('This webhook does not have a token associated with it')

thread_id: Optional[int] = None
if thread is not MISSING:
if thread:
thread_id = thread.id

adapter: WebhookAdapter = _get_webhook_adapter()
Expand Down
Loading