Fix typo, change loadpath #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebenstead
temporarily deployed
to
previews/1241/merge
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a translation file syntax error and updates the i18n configuration to properly handle file paths in different deployment environments.
- Fixed a JSON syntax error by removing an extra trailing comma in the English translation file
- Updated the i18n backend loadPath to use environment-based path resolution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/i18n.js | Updated backend loadPath to use PUBLIC_URL environment variable for proper path resolution |
| public/translations/en.json | Removed extra trailing comma causing JSON syntax error |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jamiebenstead
temporarily deployed
to
previews/1241/merge
GitHub Actions
Inactive
adrian-rpf
approved these changes
Aug 29, 2025
Merged
loiswells97
added a commit
that referenced
this pull request
Sep 19, 2025
### Added - Ability to translate demo project instructions (#1230) - Translations (#1212) ### Changed - Improved status bar styling (#1221) - Added method to translate last saved time (#1223) - Deleting unused strings and components (#1225) - Determine locale from web component attribute instead of browser path (#1244) ### Fixed - CrowdIn issue for pluralised strings with no `one` version (#1234) - Update `imagePanel.gallery` string to remove Title Casing for consistency (#1238) - Update `imageUploadButton.uploadImage` string to remove Title Casing for consistency (#1238) - Fixed typo in the `en.json` translation file (#1241) ### Removed - Remove unused translation string `filePanel.images` (#1238)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a translation typo which was causing the file to error. Fixed loadpath.