Skip to content

Plugin system for sidebar panels #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

Plugin system for sidebar panels #1251

merged 4 commits into from
Oct 7, 2025

Conversation

loiswells97
Copy link
Contributor

No description provided.

@loiswells97 loiswells97 temporarily deployed to previews/1251/merge October 6, 2025 15:56 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1251/merge October 6, 2025 16:14 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1251/merge October 7, 2025 13:19 — with GitHub Actions Inactive
adrian-rpf
adrian-rpf reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@adrian-rpf adrian-rpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this code. Really nice and clear.

  1. Should we consider the naming of some of the variables. Limiting or making it clear that that it's for use for the sidebar.

  2. How will we document how to use this plugin system? ReadMe, Example Plugin Script?

src/components/Editor/Project/Project.jsx Outdated
withProjectbar = true,
withSidebar = true,
sidebarOptions = [],
plugins = [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we should name this sidebarPlugins to limit scope/.

adrian-rpf
adrian-rpf approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@adrian-rpf adrian-rpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice change and good plan.
We have discussed this needs documenting/creating an example at a later point.

@loiswells97 loiswells97 merged commit 8608e32 into main Oct 7, 2025
8 checks passed
@loiswells97 loiswells97 deleted the sidebar-plugin-support branch October 7, 2025 15:41
This was referenced Oct 13, 2025
Closed
Merged
rammodhvadia added a commit that referenced this pull request Oct 13, 2025
@rammodhvadia
V0.32.0 (#1256)
2bff51e 
### Added

- Sidebar plugin functionality (#1251)

### Changed

- Changed `set_pixel` to quantise the colour before writing (#1247)
- Changed Prism config to use babel plugin enabling line highlighting
and numbering (#1254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrian-rpf adrian-rpf adrian-rpf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loiswells97 @adrian-rpf