Skip to content

Conversation

@krulis-martin
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new endpoint for fetching external attributes of a single group, providing webapp with a convenient way to retrieve and display group-specific attributes.

  • Adds new GET endpoint /groupExternalAttributes/<groupId> to retrieve attributes for a specific group
  • Implements actionGet method with proper ACL checks to fetch group external attributes
  • Includes comprehensive test coverage for the new endpoint functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
app/V1Module/router/RouterFactory.php Adds route configuration for the new group attributes endpoint
app/V1Module/presenters/GroupExternalAttributesPresenter.php Implements the new actionGet method with ACL validation
tests/Presenters/GroupExternalAttributesPresenter.phpt Adds test case to verify the new endpoint functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@krulis-martin krulis-martin merged commit e0e3a89 into master Sep 22, 2025
12 checks passed
@krulis-martin krulis-martin deleted the group-attrs branch September 22, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants