Skip to content

fix(ubuntu): chown more safely #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(ubuntu): chown more safely #412

wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Contributor

  • make sure the root of android stuff is chowned for installation of completely new things if needed
  • don't fail when recursively chowning specific android things, as they may not exist yet (i.e., platform-tools) when chown is attempted

@mikehardy
fix(ubuntu): chown more safely
33ee1c5 
- make sure the root of android stuff is owned for modification
- don't fail when recursively chowning specific android things, as
  they may not exist yet (i.e., platform-tools) when chown is attempted
@mikehardy
Copy link
Contributor Author

This can be considered a follow-on to #406 - which is a nice performance boost but makes assumptions about the directories existing - linux will throw a non-zero exit code if you chown something that isn't there but using a || true in the shell means that you can blindly try the chown and it's fine if it fails

@mikehardy mikehardy mentioned this pull request Oct 11, 2024
Merged
@mikehardy
Copy link
Contributor Author

chown not required at all anymore it seems - less code == better

#409 (comment)

@mikehardy mikehardy closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mikehardy