Skip to content

fix pre-launch-script #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2025
Merged

fix pre-launch-script #439

merged 3 commits into from
Jun 25, 2025

Conversation

munrocket
Copy link
Contributor

@munrocket munrocket commented Jun 24, 2025 •
edited
Loading

fixes: #346
fixes: #438

  • split the launchEmulator function in emulator-manager.ts
  • updated the main execution flow in main.ts
  • updated function signatures

Locally tested.

@ychescale9
Copy link
Member

@munrocket thanks for the fix! could you run npm run build && npm test --clean && npm run lint and check in the js files too?

@munrocket
Copy link
Contributor Author

@ychescale9 done.

@ychescale9
Copy link
Member

Thank you!

@ychescale9 ychescale9 merged commit f2bf410 into ReactiveCircus:main Jun 25, 2025
7 checks passed
vvb2060 pushed a commit to LSPosed/android-emulator-runner that referenced this pull request Sep 3, 2025
@munrocket @vvb2060
Fix pre-emulator-launch-script (ReactiveCircus#439)
0418492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizable emulator pre-emulator-launch-script runs before AVD created
2 participants
@munrocket @ychescale9