Make compatible with Json Schema pattern properties #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meverg
force-pushed
the
json_schema_pattern_properties
branch
from
dc4b9ab to
13f3a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes commits from #19 which is still not merged. #19 is a base for this PR.
Trying to use this target with
tap-jiraI noticed that the target was not able to handlepatternPropertiesfeature of the JSON Schema standard.However in BigQuery JSON schema specification there is no way to represent such field property. So I decided handling it by converting such fields to string both when loading the records and when creating the table schema.
Also with this PR I fixed some minor bugs:
logging.error()doesn't have a parameter namedsepAnd lastly I improved
fix_name()function to comply BigQuery table name constraints completely.