Migrate to functools.cached_property while preserving cached_property_with_ttl #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the project from using the external
cached_propertypackage to Python's built-infunctools.cached_propertywhere possible, while preserving the library'scached_property_with_ttlimplementation for TTL functionality.Changes Made
Import Updates
from cached_property import cached_property→from functools import cached_propertyfrom cached_property import cached_property→from functools import cached_propertyfrom cached_property import threaded_cached_property→from functools import cached_propertyfrom proto.utils import cached_property→from functools import cached_propertyDependencies
cached_propertyinpyproject.tomldependencies specifically for TTL functionalityTTL Functionality Preserved
from cached_property import cached_property_with_ttlto maintain the proven library implementation for VM state caching with 1-second TTLTechnical Details
The migration strategically handles different cached property variants:
cached_property: Migrated tofunctools.cached_property(available since Python 3.8)threaded_cached_property: Replaced withfunctools.cached_property(which is already thread-safe)cached_property_with_ttl: Preserved from the library to avoid potential issues with custom TTL implementationsThis approach reduces dependency usage while maintaining the reliability of the existing TTL caching mechanism used for VM state queries.
Fixes #514.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.