Added a single HTML page as a wrapper around the 2 independent applic… #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarhaber
reviewed
Nov 8, 2019
There was a problem hiding this comment.
Hello @nosqlgeek
Good idea (because I also had last week).
However.
That's a lot of "dirty" code for such a small task. Perhaps just keep the bare index.html w/o all the fluff (more inline with the current "bare bones" feel of the demo)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation windows.
BTW: This is just some dirty HTML code in order to not need to deal with several browser windows during talks/presentations.