Skip to content

Fix: Prevent uncatchable capability error from DefineFastFlag in client scripts #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4bdullah0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent uncatchable capability error from DefineFastFlag in client scripts #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions modules/react-roblox/src/client/roblox/RobloxComponentProps.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,31 @@ local function updateProperties(
end
end

local _, FFlagReactFixBindingMemoryLeak = xpcall(function()
return game:DefineFastFlag("ReactFixBindingMemoryLeak", false)
end, function()
return true
end)
-- ============================================================================
-- FASTFLAG INITIALIZATION WITH CONTEXT DETECTION
-- DefineFastFlag requires RobloxScript capability (server-side only)
-- Client scripts lack this capability and will throw un-catchable errors
-- Sol-> Check context first, only call DefineFastFlag in server contexts
-- ============================================================================

local FFlagReactFixBindingMemoryLeak = true -- Safe default for all contexts

-- Only attempt to DefineFastFlag in server contexts where the capability exists
local RunService = game:GetService("RunService")
local isServerContext = RunService:IsServer() and not RunService:IsClient()

if isServerContext then
-- Were in a server context safely attempt to get the FastFlag
local success, result = pcall(function()
return game:DefineFastFlag("ReactFixBindingMemoryLeak", false)
end)

if success and typeof(result) == "boolean" then
FFlagReactFixBindingMemoryLeak = result
end
-- if pcall fails we keep the safe default (true)
end
-- ^^^^^^ Note -> Client scripts always use true (the safe default with memory leak fix enabled)

local function cleanupBindings(domElement: HostInstance)
local instanceBindings = instanceToBindings[domElement]
Expand Down