Enh/motor thrustcurve api

[Marchma0]

Pull request type

• Code changes (bugfix, features)
• Code maintenance (refactoring, formatting, tests)

Checklist

• Tests for the changes have been added (if needed)
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally

Current behavior

#661

New behavior

We added the function to load a motor from the thrustcruve API and we tested it.

Breaking change

• No

[Gui-FernandesBR]

I really like this implementation!!

[Copilot]

Pull Request Overview

This PR adds a new method load_from_thrustcurve_api to the GenericMotor class that allows users to download motor data directly from the ThrustCurve.org API by providing a motor name. This feature simplifies motor initialization by eliminating the need to manually download .eng files.

• Adds API integration with ThrustCurve.org to download motor data
• Implements a new static method that searches for motors and downloads their .eng files
• Includes comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
rocketpy/motors/motor.py	Adds new static method load_from_thrustcurve_api with required imports (base64, tempfile, requests) to enable downloading and loading motor data from ThrustCurve API
tests/unit/motors/test_genericmotor.py	Adds test case to verify the new API loading functionality works correctly with Cesaroni M1670 motor data

[Gui-FernandesBR]

I see 2 major problems:

1 - Documentation: we should add a description of how to use the new feature.
2 - Tests: We should mock the API call so we don't exhaust the endpoint whenever we run the tests

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

[codecov]

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.33%. Comparing base (9cf3dd4) to head (f1cf70a).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
rocketpy/motors/motor.py	94.87%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #870      +/-   ##
===========================================
+ Coverage    80.27%   80.33%   +0.06%     
===========================================
  Files          104      104              
  Lines        12769    12815      +46     
===========================================
+ Hits         10250    10295      +45     
- Misses        2519     2520       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Monta120]

@Gui-FernandesBR Thank you for going over the code. I just updated the latest commit to run make format for import/order/style cleanup and added tests for exception handling in load_from_thrustcurve_api.

[Marchma0]

Hi all, We’ve updated the PR based on your feedback. Could you please check if it looks good now or if anything else needs improvement ?

[Gui-FernandesBR]

Hi all, We’ve updated the PR based on your feedback. Could you please check if it looks good now or if anything else needs improvement ?

@Marchma0 can you check why linters are not passing? Also, if you could please mark previous comments as "resolved", that would make our review easier

[Marchma0]

We updated the code, i think we resolved pylint errors.

[Marchma0]

Do you think there is something else to modify ? @Gui-FernandesBR

[Gui-FernandesBR]

Needs changes.

[Marchma0]

I sent you an invite to the fork. If its not working i will for sure add the requested changes for tomorow, thank you !!

[Gui-FernandesBR]

LGTM, hope it is working.

Great implementation!!