Skip to content

ENH: custom warning no motor or aerosurface #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 26, 2025
Merged

ENH: custom warning no motor or aerosurface #871

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d7b2f2
DOC: Add entry for custom warnings in CHANGELOG.md
C8H10O2 Nov 4, 2025
4eff12e
ENH: add custom warning for Rocket with no components
C8H10O2 Nov 4, 2025
a4f44c4
ENH:Add tests for _check_missing_components method in Rocket class
Bizo883 Nov 5, 2025
c00e2dd
TST:improve test_check_missing_no_components_missing to correctly han…
Bizo883 Nov 12, 2025
1d75f80
BUG: do not warn for rockets without parachute
C8H10O2 Nov 12, 2025
c787b36
TST:Update the test:do not warn when missing parachute
Bizo883 Nov 17, 2025
39a23cf
MNT: simplify checks and update docstrings in rocket.py
C8H10O2 Nov 25, 2025
43107d3
Merge branch 'develop' into enh/custom-warning-no-motor-parachute-aer…
Bizo883 Nov 25, 2025
192455e
TST:update test_check_missing_no_components_missing to avoid TypeErro…
Bizo883 Nov 25, 2025
6e16e60
TST:update test_check_missing_no_components_missing:import the lib at…
Bizo883 Nov 26, 2025
85544e6
TST:update test_check_missing_no_components_missing:import the lib at…
Bizo883 Nov 26, 2025
dc369f0
Fix lint errors
Marchma0 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions rocketpy/rocket/rocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,7 @@ def _check_missing_components(self):

if missing_components:
component_list = ", ".join(missing_components)
warnings.warn(
f"Rocket has no {component_list} defined.", UserWarning
)
warnings.warn(f"Rocket has no {component_list} defined.", UserWarning)

@property
def nosecones(self):
Expand Down
6 changes: 2 additions & 4 deletions tests/unit/rocket/test_rocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import warnings
from unittest.mock import patch

import numpy as np
import pytest
import warnings

from rocketpy import Function, NoseCone, Rocket, SolidMotor
from rocketpy.mathutils.vector_matrix import Vector
Expand All @@ -11,9 +11,7 @@


@patch("matplotlib.pyplot.show")
def test_elliptical_fins(
mock_show, calisto_robust, calisto_trapezoidal_fins
): # pylint: disable=unused-argument
def test_elliptical_fins(mock_show, calisto_robust, calisto_trapezoidal_fins): # pylint: disable=unused-argument
test_rocket = calisto_robust
calisto_robust.aerodynamic_surfaces.remove(calisto_trapezoidal_fins)
test_rocket.add_elliptical_fins(4, span=0.100, root_chord=0.120, position=-1.168)
Expand Down