Skip to content

Conversation

vitgrams
Copy link
Contributor

Done:

  • Save production doc only after all workers completed their job;
  • Added lock for tmp documentation file (for read & write as well).

@vitgrams
Copy link
Contributor Author

@DenTray Could you please review this one?

@vitgrams vitgrams self-assigned this Sep 30, 2024
@vitgrams vitgrams requested a review from DenTray September 30, 2024 05:18
@vitgrams vitgrams force-pushed the paratests branch 2 times, most recently from 4f5f786 to c64db73 Compare October 25, 2024 10:16
@vitgrams vitgrams force-pushed the paratests branch 9 times, most recently from 1a303da to d4e0f6e Compare November 29, 2024 08:23
@vitgrams
Copy link
Contributor Author

@DenTray Could you please take a look at this again?

@DenTray DenTray removed their assignment Dec 3, 2024
@vitgrams
Copy link
Contributor Author

vitgrams commented Dec 3, 2024

@DenTray Done. Could you please take a look?

@DenTray DenTray requested a review from aizlee December 6, 2024 09:15
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

{
$token = 'workerID';

ParallelTesting::resolveTokenUsing(fn () => $token);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move it to the separate helper mockParalletTestingToken and use it here and in all other tests using this logic

@DenTray DenTray assigned DenTray and unassigned RGO230 May 6, 2025
Copy link

sonarqubecloud bot commented May 6, 2025

@DenTray DenTray merged commit 204ccec into master May 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants