Skip to content

Conversation

@mee213
Copy link

@mee213 mee213 commented Nov 4, 2013

Hi Jesse,

This is my first pull request ever, so I hope I'm doing this right...

Marlo

student.rb Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about the only thing I can find to comment on... If you want an empty line, it's better to use the \n designation.

so, you could do puts "\nJuniors" and it'll have a line there

or really, even the following makes it look like you meant to have the empty line. Without might imply you forgot it was there.

puts ""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback because I was asking myself these very questions...
fixed now.

On Mon, Nov 4, 2013 at 12:55 PM, Jesse Wolgamott
notifications@github.comwrote:

In student.rb:

seniors(all_students).each do |student|

  • puts student
  • puts " * " + student.to_s
    +end

+puts

This is about the only thing I can find to comment on... If you want an
empty line, it's better to use the \n designation.

so, you could do puts "\nJuniors" and it'll have a line there

or really, even the following makes it look like you meant to have the
empty line. Without might imply you forgot it was there.

puts ""


Reply to this email directly or view it on GitHubhttps://github.com//pull/7/files#r7409313
.

@jwo
Copy link
Member

jwo commented Nov 4, 2013

Excellent job! And congrats awesome on your first pull request, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants