Add LCM for Uint #1028
Open
Add LCM for Uint #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 79.87% 79.92% +0.04%
==========================================
Files 163 164 +1
Lines 17737 17779 +42
==========================================
+ Hits 14167 14209 +42
Misses 3570 3570 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjarri
reviewed
Dec 10, 2025
| assert_eq!(lhs.lcm_uint(&rhs), target); | ||
| } | ||
|
|
||
| fn run_tests<const LIMBS: usize, const WIDE_LIMBS: usize>() |
Contributor
There was a problem hiding this comment.
What's our policy on proptests? Seems like it would be useful to have one here.
Member
There was a problem hiding this comment.
I'm definitely a fan of proptests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added the LCM for
Uintfor now, I think it should not be difficult to add it to other types as well. I have never used the Int type so if that is different, might take some time.