Enforce uniqueness of job names #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 23, 2017 18:25
|
In my application, I set a unique constraint on the name column. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was discussed briefly in PR #22 we should probably enforce uniqueness of jobs being passed to clockwork. Non-unique names could potentially cause confusion when debugging, and when the expectation is that the name is unique.
NOTE
This does not change the behaviour of the DatabaseEvents, beyond ignoring the new flag being passed. I am admittedly not familiar enough w/ DatabaseEvents to say whether this is a desirable change or whether this works w/ the current implementation of DatabaseEvents. Help in that area would be greatly appreciated :)