Skip to content

feat(ui5-button): Add BusyIndicator #11906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Jul 30, 2025
Merged

feat(ui5-button): Add BusyIndicator #11906

merged 41 commits into from
Jul 30, 2025

Conversation

GDamyanov
Copy link
Contributor

@GDamyanov GDamyanov commented Jul 14, 2025 •
edited
Loading

  • Add busy state functionality to Button component
  • Integrate BusyIndicator with appropriate sizing (S for icon-only, M for regular buttons)
  • Add busy indicator styling and positioning- Update button template to conditionally render BusyIndicator
  • Add test coverage for busy state scenarios

@GDamyanov GDamyanov self-assigned this Jul 14, 2025
hinzzx
hinzzx requested changes Jul 15, 2025
View reviewed changes
GDamyanov and others added 3 commits July 16, 2025 09:37
@GDamyanov GDamyanov requested a review from hinzzx July 16, 2025 06:48
hinzzx
hinzzx reviewed Jul 17, 2025
View reviewed changes
Stoev
Stoev reviewed Jul 21, 2025
View reviewed changes
Stoev
Stoev reviewed Jul 21, 2025
View reviewed changes
@GDamyanov GDamyanov requested a review from Stoev July 21, 2025 18:08
@GDamyanov GDamyanov requested a review from hinzzx July 22, 2025 06:37
Stoev
Stoev reviewed Jul 22, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tsanislavgatev
tsanislavgatev requested changes Jul 30, 2025
View reviewed changes
@GDamyanov GDamyanov requested a review from tsanislavgatev July 30, 2025 13:00
@GDamyanov GDamyanov merged commit acd6b6e into main Jul 30, 2025
19 of 20 checks passed
@GDamyanov GDamyanov deleted the button-busy-indicator branch July 30, 2025 13:27
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.13.0-rc.3 🎉

The release is available on v2.13.0-rc.3

Your semantic-release bot 📦🚀

@DMihaylova DMihaylova added this to the 2.13.0 milestone Aug 4, 2025
@DMihaylova DMihaylova mentioned this pull request Aug 4, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

@hinzzx hinzzx hinzzx approved these changes

Assignees

@GDamyanov GDamyanov

Labels
released
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GDamyanov @ui5-webcomponents-bot @tsanislavgatev @Stoev @hinzzx @DMihaylova