Skip to content

feat(ui5-product-switch-item): added image slot #11965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

plamenivanov91
Copy link
Contributor

@plamenivanov91 plamenivanov91 commented Jul 21, 2025

There is a new image slot which can be used instead of the old icon property.

Also a new entry is added in the AvatarColorScheme enum called Transparent in order to achieve the target design for the transparent images/SVGs in the ProductSwitchItem with image.

@plamenivanov91 plamenivanov91 marked this pull request as ready for review August 6, 2025 13:02
@plamenivanov91 plamenivanov91 changed the title feat(ui5-product-switch-item): added custom image slot feat(ui5-product-switch-item): added image slot Aug 6, 2025
Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is misalignment, in the cases when no icon, nor image is presented:
image
Compared to:
image
Also, please include the new feature in a sample in the playgound.

@plamenivanov91 plamenivanov91 merged commit 79903f4 into SAP:main Aug 13, 2025
19 of 20 checks passed
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.14.0-rc.1 🎉

The release is available on v2.14.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants