-
Notifications
You must be signed in to change notification settings - Fork 279
chore(ui5-toolbar-select): value and label added #11972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PetyaMarkovaBogdanova
wants to merge
14
commits into
main
Choose a base branch
from
add-toolbar-select-apis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
04fa785
chore(ui5-toolbar-select): value and label added
PetyaMarkovaBogdanova 0f2decc
Merge branch 'main' into add-toolbar-select-apis
PetyaMarkovaBogdanova bed5075
chore(ui5-toolbar): add select APIs to ToolbarSelectTemplate
PetyaMarkovaBogdanova 2788558
Merge branch 'main' into add-toolbar-select-apis
PetyaMarkovaBogdanova e7c64c1
chore(ui5-toolbar): add select APIs
PetyaMarkovaBogdanova 171af8b
Merge branch 'add-toolbar-select-apis' of github.com:SAP/ui5-webcompo…
PetyaMarkovaBogdanova 8a4aa5f
Merge branch 'main' into add-toolbar-select-apis
PetyaMarkovaBogdanova a5565df
chore(ui5-toolbar): add select APIs to ToolbarSelect
PetyaMarkovaBogdanova cf5b455
chore(ui5-toolbar): add select APIs to ToolbarSelect
PetyaMarkovaBogdanova b6bd247
Merge branch 'add-toolbar-select-apis' of github.com:SAP/ui5-webcompo…
PetyaMarkovaBogdanova f02f390
Merge branch 'main' into add-toolbar-select-apis
PetyaMarkovaBogdanova 967dbc0
chore(ui5-toolbar): add select APIs to ToolbarSelect
PetyaMarkovaBogdanova 577e0f5
Merge branch 'add-toolbar-select-apis' of github.com:SAP/ui5-webcompo…
PetyaMarkovaBogdanova f2b41a0
chore(ui5-toolbar): add select APIs to ToolbarSelect
PetyaMarkovaBogdanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,9 +87,23 @@ class ToolbarSelect extends ToolbarItem { | |
* **Note:** Use the `ui5-toolbar-select-option` component to define the desired options. | ||
* @public | ||
*/ | ||
@slot({ "default": true, type: HTMLElement, invalidateOnChildChange: true }) | ||
@slot({ | ||
"default": true, | ||
type: HTMLElement, | ||
invalidateOnChildChange: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need invalidateOnChildChange here? |
||
individualSlots: true, | ||
PetyaMarkovaBogdanova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}) | ||
options!: Array<ToolbarSelectOption>; | ||
|
||
/** | ||
* Defines the HTML element that will be displayed in the component input part, | ||
* representing the selected option. | ||
* @public | ||
* @since 2.13.0 | ||
*/ | ||
@slot() | ||
label!: Array<HTMLElement>; | ||
|
||
/** | ||
* Defines the value state of the component. | ||
* @default "None" | ||
|
@@ -124,6 +138,16 @@ class ToolbarSelect extends ToolbarItem { | |
@property() | ||
accessibleNameRef?: string; | ||
|
||
/** | ||
* Defines the value of the component: | ||
* | ||
* @public | ||
* @default "" | ||
* @since 2.13.0 | ||
*/ | ||
@property() | ||
value?: string; | ||
|
||
onClick(e: Event): void { | ||
e.stopImmediatePropagation(); | ||
const prevented = !this.fireDecoratorEvent("click", { targetRef: e.target as HTMLElement }); | ||
|
@@ -174,6 +198,10 @@ class ToolbarSelect extends ToolbarItem { | |
width: this.width, | ||
}; | ||
} | ||
|
||
get hasCustomLabel() { | ||
return !!this.label.length; | ||
} | ||
} | ||
|
||
ToolbarSelect.define(); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this test to a ToolbarSelect.cy.tsx file and test the value and slot members separately.
Also add few more tests for the value property, for example changing the value should change the selection or passing a value that has no corresponding option, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also test with the ui5-toolbar-select-option component