-
Notifications
You must be signed in to change notification settings - Fork 14
Reopened: PMT Software Trigger class #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f to keep with v10_00_13
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @kjplows wrote, I would appreciate documenting the data members of the new class (see the old comment).
The rest is good.
|
thanks @kjplows for fixing the checksum!!! and thank you @PetrilloAtWork for pointing out the missing documentation, hopefully this takes care of it! |
linyan-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!!! Thank you all so so much...!
|
@PetrilloAtWork's request for documentation is addressed by commit b104267. With my deep gratitude to all contributors for their amazing work, I am running CI now for good luck. If all is well, I will consider this approved, and proceed with a release. |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
The CI is happy, ClassDef is happy, documentation is in. Merging. |
Quick checklist
git fetchand pulled the latest changes from the branch you're basing your PR against?ClassVersionby one compared to develop in classes_def.xml?Description
Reopened #174 after @PetrilloAtWork caught (in the very, very last minute!) a breaking issue with
classes_def.xml.Summoning him and @linyan-w to review.
Summoning the original author, @lynnt20 , to implement changes. I have implemented fixes to
classes_def.xml, @PetrilloAtWork has also requested documentation additions.