Skip to content

Conversation

@kjplows
Copy link
Contributor

@kjplows kjplows commented Nov 21, 2025

Quick checklist

  • [ x] Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
  • [ x] If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • [ x] Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
  • [ x] If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?

Description

Reopened #174 after @PetrilloAtWork caught (in the very, very last minute!) a breaking issue with classes_def.xml.
Summoning him and @linyan-w to review.
Summoning the original author, @lynnt20 , to implement changes. I have implemented fixes to classes_def.xml, @PetrilloAtWork has also requested documentation additions.

@kjplows kjplows added the bug Something isn't working label Nov 21, 2025
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @kjplows wrote, I would appreciate documenting the data members of the new class (see the old comment).
The rest is good.

@lynnt20
Copy link
Contributor

lynnt20 commented Nov 21, 2025

thanks @kjplows for fixing the checksum!!! and thank you @PetrilloAtWork for pointing out the missing documentation, hopefully this takes care of it!

Copy link

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!! Thank you all so so much...!

@kjplows
Copy link
Contributor Author

kjplows commented Nov 21, 2025

@PetrilloAtWork's request for documentation is addressed by commit b104267. With my deep gratitude to all contributors for their amazing work, I am running CI now for good luck. If all is well, I will consider this approved, and proceed with a release.

@kjplows
Copy link
Contributor Author

kjplows commented Nov 21, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this to To merge in SBN software development Nov 21, 2025
@kjplows
Copy link
Contributor Author

kjplows commented Nov 21, 2025

The CI is happy, ClassDef is happy, documentation is in. Merging.

@kjplows kjplows merged commit 29cdabc into develop Nov 21, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants