Skip to content

Removal of detrimental dependency of sbnobj::Common_CRT #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PetrilloAtWork wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Removal of detrimental dependency of sbnobj::Common_CRT #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db448a1
Removed accidental (and detrimental) dependency on larcorealg::Geometry
PetrilloAtWork Oct 23, 2025
6d8e993
Restored initialization of sbn::crt::CRTPMTMatching data members
PetrilloAtWork Oct 23, 2025
2d141a1
Merge branch 'develop' into feature/gp_CRTlibDeps
kjplows Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sbnobj/Common/CRT/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ cet_make_library(
CRTHitT0TaggingTruthInfo.cc
LIBRARIES
cetlib_except::cetlib_except
lardataobj::Simulation
larcorealg::Geometry
larcoreobj::headers
lardataobj::Simulation # for associations to sim::AuxDetIDE
)

art_dictionary(DICTIONARY_LIBRARIES sbnobj::Common_CRT)
Expand Down
4 changes: 2 additions & 2 deletions sbnobj/Common/CRT/CRTHitT0TaggingInfo.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

// C/C++ standard libraries
#include <limits>
#include "larcorealg/Geometry/GeometryCore.h"
#include "larcoreobj/SimpleTypesAndConstants/geo_types.h"
#include "larcoreobj/SimpleTypesAndConstants/geo_vectors.h"

// -----------------------------------------------------------------------------
namespace sbn::crt {
/// @brief How was the track fitted when matched with a CRT hit.
Expand Down Expand Up @@ -100,4 +100,4 @@ struct sbn::crt::CRTHitT0TaggingInfo {
// -----------------------------------------------------------------------------


#endif // SBNOBJ_COMMON_CRTHitT0TaggingInfo_hh_
#endif // SBNOBJ_COMMON_CRTHitT0TaggingInfo_hh_
30 changes: 15 additions & 15 deletions sbnobj/Common/CRT/CRTPMTMatching.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ namespace sbn::crt {
static constexpr int NoLocation = -1;

geo::Point_t position; ///< Hit location [cm]
double PMTTimeDiff; //= NoTime; < CRT hit time minus PMT flash time [us] (instead maybe wanna set NoTime vars in
double time;// = NoTime; ///< CRT hit time [us]
int sys; // = NoLocation; ///< CRT subdetector the hit fell into.
int region;// = NoLocation; ///< Region the matched CRT hit fell into.
double PMTTimeDiff = NoTime; ///< CRT hit time minus PMT flash time [us]
double time = NoTime; ///< CRT hit time [us]
int sys = NoLocation; ///< CRT subdetector the hit fell into.
int region = NoLocation; ///< Region the matched CRT hit fell into.
};

struct CRTPMTMatching{
Expand All @@ -83,18 +83,18 @@ namespace sbn::crt {
static constexpr double NoWidth = -1.0;


int flashID;// = NoID; ///< ID of the optical flash.
double flashTime;// = NoTime; ///< Time of the optical flash w.r.t. the global trigger [us]
double flashGateTime;// = NoTime; ///< Time of the optical flash w.r.t. the beam gate opening [us]
double firstOpHitPeakTime;// = NoTime; ///< Time of the first optical hit peak time w.r.t. the global trigger [us]
double firstOpHitStartTime;// = NoTime; ///< Time of the first optical hit start time w.r.t. the global trigger [us]
bool flashInGate;// = false; ///< Flash within gate or not.
bool flashInBeam ;// = false; ///< Flash within the beam window of the gate or not.
double flashPE;// = -1.0; ///< Total reconstructed light in the flash [photoelectrons]
int flashID = NoID; ///< ID of the optical flash.
double flashTime = NoTime; ///< Time of the optical flash w.r.t. the global trigger [us]
double flashGateTime = NoTime; ///< Time of the optical flash w.r.t. the beam gate opening [us]
double firstOpHitPeakTime = NoTime; ///< Time of the first optical hit peak time w.r.t. the global trigger [us]
double firstOpHitStartTime = NoTime; ///< Time of the first optical hit start time w.r.t. the global trigger [us]
bool flashInGate = false; ///< Flash within gate or not.
bool flashInBeam = false; ///< Flash within the beam window of the gate or not.
double flashPE = -1.0; ///< Total reconstructed light in the flash [photoelectrons]
geo::Point_t flashPosition; ///< Flash barycenter coordinates evaluated using ADCs as weights.
double flashYWidth;// = NoWidth; ///< Flash spread along Y.
double flashZWidth;// = NoWidth; ///< Flash spread along Z.
MatchType flashClassification;// = MatchType::noMatch; ///< Classification of the optical flash.
double flashYWidth = NoWidth; ///< Flash spread along Y.
double flashZWidth = NoWidth; ///< Flash spread along Z.
MatchType flashClassification = MatchType::noMatch; ///< Classification of the optical flash.
std::vector<MatchedCRT> matchedCRTHits; ///< Matched CRT Hits with the optical flash.
unsigned int nTopCRTHitsBefore = NoCount; ///< Number of Top CRT Hits before the optical flash.
unsigned int nTopCRTHitsAfter = NoCount; ///< Number of Top CRT Hits after the optical flash.
Expand Down