-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: show checkedName for selected checkbox options #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sakthieswaran-tech
wants to merge
15
commits into
SBoudrias:main
Choose a base branch
from
Sakthieswaran-tech:feature/checkbox-checked-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
02928ea
feat: display checkedName in checkbox prompt
Sakthieswaran-tech 5003a30
Chore(deps-dev): Bump the linting group with 3 updates (#1845)
dependabot[bot] 1d96e81
Chore(deps-dev): Bump globby from 14.1.0 to 15.0.0 (#1846)
dependabot[bot] 428c989
Chore(deps-dev): Bump tshy from 3.0.2 to 3.0.3 (#1849)
dependabot[bot] 9bb5c18
fix: stricter type
SBoudrias 2650401
doc: add new option to README
SBoudrias e016ff8
fix: e2e tests
SBoudrias 5b8d8db
fix: e2e tests
SBoudrias 1926a19
fix: e2e test
SBoudrias d1de2fb
fix: e2e test
SBoudrias 8cc248a
feat: display checkedName in checkbox prompt
Sakthieswaran-tech cc30dcb
merge conflict resolved
Sakthieswaran-tech 3962ec2
fixed the descriptor syntax
Sakthieswaran-tech cc092ac
build packages before e2e to include latest type changes
Sakthieswaran-tech 00c9736
type fix
Sakthieswaran-tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what's breaking the e2e test.
Resources:
The
<descriptor>
isn't correct to link the prompt packages required by@inquirer/prompts
to use the one from the repo.I'm short on time to figure the exact syntax, but that's the problem. Hopefully it gives you enough to research a bit the issue 🤞🏻