Bio geochemistry #19
Merged
Bio geochemistry #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
author Elyes Ahmed <elyes.ahmed@sintef.no> 1729779225 +0200 committer Elyes Ahmed <elyes.ahmed@sintef.no> 1739189245 +0100 adding H2 storage examples adding second example add third example minor adding thermo adding thermo example HS eos and some cleanup readme file adding biochemisty some fixes adding biochemistry and optimization scripts fixes and new example modele de Soreide_Whitson VLE modif test NEW EOS securite BIC H2, ajout CO2 securite BIC H2, ajout CO2 securite BIC H2, ajout CO2 a separete Soreide Whitson EOS for H2-brine fixing test case and mixing parameters adding bic for ch4, co2 and N2 Soreide whitson EOS cleaning example thermo SW Update README.md rm H2_H2O_VaporLiquidEquilibrium20241203.m VLE examples H2-H2O and CO2-H2O with the SW model nettoyage VLE SW correct example CO2-H2O clean equationofstatemodel cleaning the cases Update README.md Create README.md Update README.md removing Stephanie changes here clean SoreideWhitsonEquationOfStateModel.m and rename example compositionalBacterial_WG_5components.m adding more bics minor correction cleaning benchmark example: CH4->C1, CompositionalMixture.m: N2 coefficients modifications and add an exponent to to the coef structure for msalt fixing rate as source Update README.md Update README.md some fixes for the rate minor add CO2 case with msalt=0 gammak modif add gammak molecular diffusion, mol_diff mol_diff structure modified initCompositionalStateBacteria correction and clean benchmark2023_EAGE en cours de validation benchmark2023_EAGE example modif CompositionalBacterial_benchmark2023_EAGE20250107.m fixes and bechmark running working on benchmark removing density dependance new fixes benchmark 2023AEGE ok, Gammak modified in biochemistry model benchmarck 2023AEGE for cluster uppa update examples working on EAGE example, not very interesting one i think! fix the benchmark, finally fixing case fixing more examples minor minor fixes changes fixing eos åhase labeling fitting benchmark minor minor add figures fixes on the eos for case without water adding 1d example adding dynamic pv and Trans new trial for Y yield factor working on the 1d case fixing example adding minor fixes clean 1d example fixing nothing important just to be on same commit fixing finally problem of scaling cleaning formulation and examples fixing scaling for large models adding last status before paper submission cleaning cleaning cleaning module futher cleaning cleaning paper cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bio-chemistry module for simulating compositional +bio effects in UHS. We added SW EOS and modified the compositional module to get this new EOS. Another PR will come with equilibrium examples moved to the compositional module