feat: イベント参加者のメンバー順を固定する #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements fixed member ordering for event participants by adding a createdAt field to event reservation users response and sorting by registration datetime. It also improves local development with seed data insertion.
- Added
createdAtfield to event reservation user response structure for consistent member ordering - Updated database query to include registration timestamp and sort by
created_atASC - Added comprehensive seed data for local development environment
- Added Makefile improvements and
CLAUDE.mddocumentation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schema/test/insert_test.sql | Comprehensive seed data for all tables including users, events, reservations, works, groups, and budgets |
| pkg/event/get_event_event_id_reservation_id.go | Added CreatedAt field to eventReservationObjectUser struct |
| pkg/db/sql/event/select_event_reservation_user_from_event_id_reservation_id.sql | Updated query to include created_at field and ORDER BY created_at ASC |
| pkg/api/spec.gen.go | Generated API specification update with new field |
| pkg/api/models.gen.go | Generated model with CreatedAt time.Time field |
| document/schemas/res_get_event_event_id_reservation_id.user.yml | Added createdAt field definition to OpenAPI schema |
| document/bundle.gen.yml | Generated bundle with createdAt field |
| document/bundle-develop.gen.yml | Generated develop bundle with createdAt field |
| Makefile | Fixed pipe syntax for insert_test command and added UTF-8 charset |
| CLAUDE.md | Comprehensive documentation for Claude Code usage in Japanese |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
saka-naname
reviewed
Sep 5, 2025
| Name string `db:"username"` | ||
| UserIcon string `db:"icon_url"` | ||
| UserId string `db:"user_id"` | ||
| UserName string `db:"username"` |
There was a problem hiding this comment.
db:"username" と紐付くプロパティが Name と UserName の2つになっている点が気になります
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #213
変更内容
createdAtフィールドを追加し、登録日時順でソートするよう改修make insert_testでシードデータを投入可能CLAUDE.mdを追加