Skip to content

Fix oversight where Scanner.cs won't scan for files if an archive extracts to one or more directories #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 2 commits into from
Nov 29, 2025
Merged

Fix oversight where Scanner.cs won't scan for files if an archive extracts to one or more directories #397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b4fe7
Scanner.cs won't scan for files if an archive extracts to a directory
HeroponRikiBestest Nov 29, 2025
26887c8
use fsentries
HeroponRikiBestest Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BinaryObjectScanner/Scanner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ private ProtectionDictionary GetInternalProtections(string fileName, Stream stre
_ = extractable.Extract(tempPath, _includeDebug);

// Check if any files extracted
if (IOExtensions.SafeGetFiles(tempPath).Length > 0)
if (IOExtensions.SafeGetFiles(tempPath).Length > 0 || IOExtensions.SafeGetDirectories(tempPath).Length > 0)
{
// Scan the output path
var subProtections = GetProtectionsImpl(tempPath, depth + 1);
Expand Down