Skip to content

Fix bug in IsValueType #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Fix bug in IsValueType #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Cpp2IL.Core/Model/Contexts/TypeAnalysisContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,20 @@ public static ITypeInfoProvider GetSndnProviderForType(ApplicationAnalysisContex
string ITypeInfoProvider.RewrittenTypeName => Name;
string ITypeInfoProvider.TypeNamespace => Namespace;
public virtual bool IsGenericInstance => false;
public virtual bool IsValueType => Definition?.IsValueType ?? BaseType is { Namespace: "System", Name: "ValueType" };
public virtual bool IsValueType
{
get
{
if (Definition is not null)
return Definition.IsValueType;

if (BaseType is { Namespace: "System", Name: "ValueType" })
return Namespace is not "System" || Name is not "Enum"; // Enum is a reference type

return IsEnumType;
}
}

public bool IsEnumType => Definition?.IsEnumType ?? BaseType is { Namespace: "System", Name: "Enum" };
IEnumerable<ITypeInfoProvider> ITypeInfoProvider.GenericArgumentInfoProviders => [];
IEnumerable<IFieldInfoProvider> ITypeInfoProvider.FieldInfoProviders => Fields;
Expand Down
Loading